Skip to content

Rename log -> verbose. Add LatentLoader back to fix notebooks. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luciaquirke merged 4 commits into from
Feb 17, 2025
Merged

Rename log -> verbose. Add LatentLoader back to fix notebooks. #75

luciaquirke merged 4 commits into from
Feb 17, 2025

Conversation

@luciaquirke
Copy link
Contributor

@luciaquirke luciaquirke commented Feb 16, 2025 •
edited
Loading

This PR has many changes but they're all small:

  • use a default value for n_examples_shown that doesn't leak answers
  • fix bug where verbose mode changes explainer return type
  • add LatentLoader back to fix a broken notebook which wasn't superseded by the CLI
  • rename log -> verbose in CLI
  • fix all the JSON formatting

@luciaquirke luciaquirke changed the title Rename log -> verbose, add LatentLoader back to fix notebooks Rename log -> verbose; add LatentLoader back to fix notebooks Feb 16, 2025
@luciaquirke luciaquirke changed the title Rename log -> verbose; add LatentLoader back to fix notebooks Rename log -> verbose. Add LatentLoader back to fix notebooks. Feb 16, 2025
@luciaquirke
Format all jsons with line breaks; use default value that doesn't lea…
1e61d08 
…k answers in scorers; fix bug where verbose=True changes a return type
@luciaquirke luciaquirke merged commit 8c607b3 into main Feb 17, 2025
2 checks passed
@SrGonao SrGonao mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luciaquirke