Neighbour latents for non-activating examples #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: save tokens in cache, make it the primary source of truth
SrGonao
force-pushed
the
neighbour_latents
branch
from
6f85fb2 to
eb11854
Compare
for more information, see https://pre-commit.ci
norabelrose
requested changes
Feb 18, 2025
Member
norabelrose
left a comment
norabelrose
left a comment
There was a problem hiding this comment.
some smallish changes needed
I guess the biggest question is whether we need CuPy
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
end2end tests run
I added 2 ways to compute neighbourhood between latents, but only added co-occurence to the end2end script (co-occurence only needs the cache, which we have).
Reformulated a bit the explainer to prepare for the future.
Fixed a bunch of type mismatches