Trying to fix all static type errors #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Collaborator
Author
|
Changed to jaxtyping, keeping the tensor shapes but not throwing static type errors on pylance. |
Collaborator
Author
|
There's still some type errors but I think the only way to fix them is with #type:ignore? |
added 2 commits
February 18, 2025 13:56
Collaborator
Author
|
Just noticed that this didn't fix the errors in classifiers (because I hadn't opened those files). I'm running through them in the neigbhouring latents branch, mostly because I'm changing a bit the classifiers there and don't want to fix it twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a question in #83