Skip to content

Conversation

@luciaquirke
Copy link
Contributor

@luciaquirke luciaquirke commented Mar 4, 2025

  • Keep the types correct in new PRs
  • Add type: ignores to existing type errors

Matching the setup in https://github.com/EleutherAI/elk/blob/main/.github/workflows/cpu_ci.yml

@luciaquirke luciaquirke force-pushed the add-pyright branch 2 times, most recently from ed1a6d1 to 7cb983b Compare March 4, 2025 23:48
@luciaquirke luciaquirke requested a review from SrGonao March 5, 2025 01:15
@luciaquirke luciaquirke changed the title [WIP] Add pyright to CI Add pyright to CI Mar 5, 2025
@luciaquirke luciaquirke merged commit b3df1a1 into main Mar 7, 2025
3 checks passed
@SrGonao SrGonao deleted the add-pyright branch June 3, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants