marketplace: EKS add-on delivery option template#238
Merged
Conversation
Adds an EksAddOnDeliveryOptionDetails delivery option so Signals is installable from the Amazon EKS add-on catalog (console / aws eks create-addon), alongside the live Helm/EKS and container-image options. Reuses the same re-hosted Marketplace-ECR image AND chart (one artifact set, installed three ways); additive, does not touch the existing options. - specifications/marketplace-eks-addon-delivery.md (+ .acceptance.md): ACTIVE integration-mapping spec pinning the same-image/chart invariant, behavioral parity, and the immutable identity (AddOnName/AddOnType/Namespace fixed across versions). - docs/marketplace/catalog-api/05-add-eks-addon-delivery.json: additive AddDeliveryOptions template. AddOnName=signals, AddOnType=observability, Namespace=signals; SupportedArchitectures amd64+arm64; CompatibleKubernetesVersions parameterized (K8S_VERSIONS) so only tested EKS versions are declared. - scripts/marketplace-changeset.sh: preflight guard rejecting an unsupported AddOnType before start-change-set (immutable field; costly to get wrong); usage header for step 05. - docs/marketplace/catalog-api/README.md: EKS add-on row incl. immutability + the separate add-on visibility step. AddOnType observability confirmed with product owner. Live add-on smoke (TC-EAO-05) and the submission remain a gated operator step. Refs #236, #233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #233 (Marketplace reach expansion). Adds an
EksAddOnDeliveryOptionDetailsdelivery option so Signals is discoverable and installable from the Amazon EKS add-on catalog (console /aws eks create-addon/eksctl), alongside the live Helm/EKS and container-image (#234) options. Reuses the same re-hosted Marketplace-ECR image and chart — one artifact set, installed three ways. Additive; existing options untouched.What's here (in-repo artifacts)
specifications/marketplace-eks-addon-delivery.md(ACTIVE) +.acceptance.md— integration-mapping spec. Load-bearing points:ContainerImages/HelmChartUrimust be the same digest as the Helm option's.AddOnName/AddOnType/Namespaceare fixed across all future versions (INCOMPATIBLE_ADDON_*if changed).docs/marketplace/catalog-api/05-add-eks-addon-delivery.json— additive template.AddOnName: signals,AddOnType: observability,Namespace: signals,SupportedArchitectures: [amd64, arm64],CompatibleKubernetesVersionsparameterized viaK8S_VERSIONS.scripts/marketplace-changeset.sh— newAddOnTypepreflight guard (AWS only validates post-submit, and it's immutable — costly to typo); step-05 usage header.docs/marketplace/catalog-api/README.md— EKS add-on row with the immutability + visibility notes.Decisions (confirmed)
AddOnType: observability— confirmed with product owner. Immutable, so locked deliberately; Signals is diagnostic collection, which is the modern EKS observability framing.AddOnName/Namespace=signals(matches the chart's release namespace).CompatibleKubernetesVersionsis operator-supplied at submit (K8S_VERSIONS) so we declare only tested EKS versions — a stale hardcoded default would silently over-claim.Validation
shellcheckclean; template renders to valid JSON, 0 leftover${}, 0 non-ASCII;AddOnTypeguard passes valid and catches an injected bad value;trivy fs --scanners secret .clean.Not done by merging this
The AWS
AddDeliveryOptionssubmission + the live EKS add-on install smoke (TC-EAO-05) are a gated operator step (one review round; add-on visibility is a separate publish). So this isRefs #236, notcloses.Refs #236, #233