Skip to content

Fix release packaging - #2

Merged
EleventhLucas merged 2 commits into
mainfrom
agent/fix-release-packaging
Aug 2, 2026
Merged

Fix release packaging#2
EleventhLucas merged 2 commits into
mainfrom
agent/fix-release-packaging

Conversation

@EleventhLucas

Copy link
Copy Markdown
Owner

Summary

Fixes the first post-merge Release workflow failure and completes the release package metadata.

  • Writes a real trailing newline when temporarily setting the release package version, keeping package.json valid on Windows.
  • Sets a non-personal Debian maintainer so .deb packaging does not require an author email.
  • Ships the repository license and a privacy notice in release artifacts.

Root cause

The release workflow wrote the two literal characters \\n after package.json, which made Windows E2E fail to parse it. Linux packaging then failed because Electron Builder requires either an author email or an explicit Debian maintainer.

Validation

  • Exact release package-version rewrite parsed successfully and ended with a real newline.
  • npm run typecheck
  • npm run prepare:codex && npm run package:linux -- --publish never
  • Verified the generated .deb contains resources/notices/LICENSE and resources/notices/PRIVACY.md.

The Windows path is covered by the PR CI matrix; the change removes the shell-escaping ambiguity that caused its prior JSON parse failure.

@EleventhLucas
EleventhLucas marked this pull request as ready for review August 2, 2026 04:30
@EleventhLucas
EleventhLucas merged commit 5f1959a into main Aug 2, 2026
5 checks passed
@EleventhLucas
EleventhLucas deleted the agent/fix-release-packaging branch August 2, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant