Add error wrapping in the obj package - #34
Merged
Conversation
Contributor
Author
|
I've fixed parsing as well. That branch is based on this one so I'll rebase and PR the fix after this is merged. |
Owner
|
This is great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error wrapping throughout the
objpackage, to help debugging.I came across an oddly formed .obj file, a product of conversion from STL by some online converter, and it is failing to parse. Debugging that turned out to be very difficult without wrapping as it was just
strconv.Atoi: parsing "": invalid syntaxmessage with no details of what, where or why. This PR fixes that.