feature: Add flag to optionally turn cylinder primitive into pipe - #35
Merged
Merged
Conversation
Contributor
Author
|
I thought of adding another dedicated |
Owner
|
Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to make a cylinder with one side open, optimizing for minimal triangles in this mesh, as I have a lot of copies of it in my resulting model. So I've added flags into the
primitives.Cylinderto optionally not generate top and/or bottom of the cylinder and skip those triangles.Flags are set to positive by default, so preserve current behavior of the existing code.
I didn't try to optimise local allocations to not create the corresponding meshes at all. This only prevents including them into resulting mesh. I can do that easily if it's worth it.