Drop floating point noise in color values - #44
Merged
Conversation
EliCDavis
approved these changes
Dec 6, 2024
EliCDavis
left a comment
Owner
There was a problem hiding this comment.
Oh man it was that easy huh. Man I was afraid I was going to have to create a special datatype that overrides how it get's serialized to JSON.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the floating point long trails of meaningless dust values in serialised color values.
I've opted to hardcode it to 3 decimal points because this should fully cover resolution provided by
color.Colorinteger values. So no higher precision is necessary here, and this threshold is unlikely to ever change.This only affects color values since those have well known precision, limited by RGBA data structure. No other values affected.
This actually doesn't affect my case, because
dracotranscoder already takes care of it, and even without it the difference is not huge. But it was also very easy to do, so I've dropped this one in.It didn't need JSON serialisation override, JSON is smart enough to not output trailing zeros, so correct rounding was enough here.