perf(render): compute viewer exclusions only for occupied seats#57
Closed
TypeThe0ry wants to merge 2 commits into
Closed
perf(render): compute viewer exclusions only for occupied seats#57TypeThe0ry wants to merge 2 commits into
TypeThe0ry wants to merge 2 commits into
Conversation
Arbousier1
force-pushed
the
codex/perf-render-viewer-membership
branch
from
July 16, 2026 04:29
5cd5133 to
1034f7c
Compare
Arbousier1
force-pushed
the
codex/perf-render-viewer-membership
branch
from
July 16, 2026 05:38
f74e89d to
696e10f
Compare
Member
Author
Trusted performance decisionGitHub A/B run Build/Test are green and the infrastructure is healthy; however, the measured gain did not clear the trusted threshold. This candidate will not be merged or described as an optimization. Decision artifact: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure performance scope
This PR changes only the render-snapshot viewer exclusion precomputation and its behavior-preservation test. It does not change game rules, render ordering, visibility policy, packets, timers, interaction handling, or supported platforms.
Candidate
Before this change, every render snapshot built an exclusion UUID list and membership signature for every online viewer, although the snapshot only consumes those values for the four occupied seats.
The candidate computes the same sorted/distinct viewer-derived values only for occupied seats that are actually online:
Evidence gate
No performance claim is made from source inspection. GitHub is the authoritative validator.
Required before merge recommendation:
snapshotprofile completes A/A drift controlThe existing protected benchmark covers the real production
TableRenderSnapshotFactoryat 4, 32, and 128 viewers. This PR must not alter that benchmark or its thresholds.