fix(unitframes): weapon enchant swipe not hiding duration swipe - #2016
Merged
EllesmereGaming merged 1 commit intoSep 8, 2026
Merged
Conversation
…pe toggle The Player Aura Bars weapon-enchant cells gated their duration swipe with Cooldown:SetShown alone, and PaintContent's SetCooldown re-shows the frame in the same pass. A cooldown started while the frame was hidden then renders as a wedge that never advances, so turning the swipe off left either a frozen swipe or nothing behind, depending on which of the two writes landed last for that button in that pass. Gate the swipe as persistent cooldown style instead: SetDrawSwipe plus alpha 0 on the cooldown frame, change-guarded, applied from ApplyStyle and from PaintContent so a toggle flipped in lockdown still lands. Both calls are in the render class the secure trio already relies on; SetShown stays in ApplyStyle, which runs out of combat only, since Show/Hide is blocked on a protected frame's descendants. Also poke WeaponEnchants_Layout from RestyleBars. RestyleSoon only reaches the engine buttons, so the callers that restyle without ApplyLiveConfig (global font and outline changes, profile and spec-override swaps through the _EUF_ReloadFrames tail) left the enchant cells on the previous style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Turning off "Show Duration Swipe" on the Player Aura Bars buff bar now also turns it off on the Weapon Enchants cells. Until now the toggle left the oil and imbue icons with a dark cooldown wedge that sat frozen for the entire duration of the enchant, or with no swipe at all, depending on the pass.
The cells gated the swipe with
Cooldown:SetShownalone, andPaintContent'sSetCooldownre-shows the frame in the same pass. A cooldown started while the frame was hidden then renders a wedge that never advances, so which of the two writes landed last for a given button decided what the player saw. The gate now uses persistent cooldown style instead:SetDrawSwipeplus alpha 0 on the cooldown frame, change-guarded, applied both fromApplyStyleand fromPaintContentso a toggle flipped during combat still lands.SetShownstays in the out-of-combat path, because Show/Hide is blocked on the secure trio's descendants. As a side effect the finish bling on the enchant icons is suppressed as well while the swipe is off.Second fix in the same area:
RestyleBarsnow pokesWeaponEnchants_Layout.AK.RestyleSoononly reaches engine buttons, so the callers that restyle withoutApplyLiveConfig(global font and outline changes, profile switches and spec-override swaps through the_EUF_ReloadFramestail) left the enchant cells rendering with the previous profile's style.How was it tested?
Tested in game on the live client.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames