fix(release): strip leading v from version so Homebrew formula is valid - #211
Merged
Merged
Conversation
The publish-npm and update-homebrew jobs extracted the version with
${GITHUB_REF_NAME##*-v}, which only strips up to a `-v`. Release tags are
`vX.Y.Z` (no `-v`), so the `v` was kept — the Homebrew formula got
`version "vX.Y.Z"`, and since its URLs are `.../download/v#{version}/...` that
produced a double-v `vvX.Y.Z` download URL (404) plus a `brew audit --strict`
failure. Use ${GITHUB_REF_NAME#v} like the sync-skills/smoke-test jobs already
do. (npm coerced the leading v away, so publish was unaffected, but harden it
for consistency.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WUhYjxo3aEXF4RZE1oRmtL
ckivisild-elnora-ai
approved these changes
Jul 16, 2026
rjamul-elnora-ai
pushed a commit
that referenced
this pull request
Jul 16, 2026
🤖 I have created a release *beep* *boop* --- ## [2.5.2](v2.5.1...v2.5.2) (2026-07-16) ### Bug Fixes * **release:** strip leading v from version so Homebrew formula is valid ([#211](#211)) ([ac2c888](ac2c888)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: elnora-automation-bot[bot] <294956319+elnora-automation-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the daily 'CI / Validate formula' failures on homebrew-cli and the broken
brew install.Root cause: the
publish-npmandupdate-homebrewjobs extract the version with${GITHUB_REF_NAME##*-v}, which only strips up to a-v. Tags arevX.Y.Z(no-v), so thevsurvived → the formula gotversion "vX.Y.Z", and because its URLs are.../download/v#{version}/...that became a double-vvvX.Y.ZURL (404).brew audit --strictcorrectly failed on the leadingv.Fix: use
${GITHUB_REF_NAME#v}(→X.Y.Z), matching thesync-skillsandsmoke-testjobs that already do this. Next release regenerates a valid formula. (npm silently coerced thevaway so publishing wasn't broken, but the same pattern is hardened for consistency.)Paired with a homebrew-cli PR that fixes the currently-published formula so
brew installworks before the next release.🤖 Generated with Claude Code
https://claude.ai/code/session_01WUhYjxo3aEXF4RZE1oRmtL