This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Get closer to testing NO_DCE in CI #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only remaining validation issues are due to the SROA pass not being implemented yet
eddyb
reviewed
Dec 4, 2020
eddyb
reviewed
Dec 4, 2020
Comment on lines
+217
to
+219
| // In all likelihood, this zombie message will get overwritten in SpirvValue::def_with_span | ||
| // to the use site of this constant. However, if this constant happens to never get used, we | ||
| // still want to zobmie it, so zombie here. |
There was a problem hiding this comment.
Oops, we probably want a set of Spans, I dropped the ball on that.
eddyb
approved these changes
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining validation issues are due to the SROA pass not being implemented yet