Fix distance-per-infraction aggregation using global totals - #553
Merged
Conversation
Victorbares
marked this pull request as ready for review
August 7, 2026 08:01
vcharraut
approved these changes
Aug 7, 2026
Collaborator
|
Makes sense. Min 1 infraction per scenario is quite a lot because scenarios are short, especially in nuPlan. Need to recompute metrics with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes avg_distance_per_infraction from the mean of per-scenario averages to a global average computed from total distance and total infractions.
A small example of the new avg_distance computed compare to the old one :