Merged
Conversation
2 builds increased size
HackerNews 3.4 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.Fixups | ⬆️ 4.9 kB |
| HackerNews.BookmarksScreen.body | ⬆️ 4.4 kB |
| HackerNews.StoryRow.body | ⬆️ 3.5 kB |
| 📝 HackerNews.Bookmark.Bookmark | ⬆️ 2.4 kB |
| 📝 HackerNews.AppViewModel.init(bookmarkStore) | ⬆️ 1.7 kB |
View Treemap
HackerNews 3.4 (1)
com.emergetools.hackernews.snapshots
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 189.3 kB (1.44%)
Total download size change: ⬆️ 43.6 kB (0.55%)
Largest size changes
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 75.1 kB |
| HackerNews.BookmarksScreen.body | ⬆️ 7.5 kB |
| DYLD.Fixups | ⬆️ 5.2 kB |
| Code Signature | ⬆️ 5.2 kB |
| HackerNews.StoryRow.body | ⬆️ 5.0 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test8 modified, 74 unchanged
🛸 Powered by Emerge Tools |
Merged
trevor-e
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds the infrastructure for bookmarking. It's leveraging SwiftData, albeit not in the exact way that's recommended since we are using ViewModels for data retrieval and mapping to state.
There are still probably some kinks to iron out here. I'm calling a lot of fetches to get the latest version of out bookmarks when ideally I can just observe some changes.