Skip to content

Settings Screen Design#306

Merged
trevor-e merged 9 commits intomainfrom
settings-screen-design
Jan 22, 2025
Merged

Settings Screen Design#306
trevor-e merged 9 commits intomainfrom
settings-screen-design

Conversation

@Rahkeen
Copy link
Contributor

@Rahkeen Rahkeen commented Jan 18, 2025

Adding the New Settings Screen Components:

  • Login Row
  • Settings Row for Links

@Rahkeen Rahkeen changed the title settings-screen-design Settings Screen Design Jan 18, 2025
Copy link
Contributor Author

Rahkeen commented Jan 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Rahkeen Rahkeen marked this pull request as ready for review January 18, 2025 00:29
Base automatically changed from bookmarking to main January 22, 2025 20:11
@emerge-tools
Copy link

emerge-tools bot commented Jan 22, 2025

2 builds increased size

Name Version Download Change Install Change Approval
HackerNews
com.emerge.hn.Hacker-News
3.4 (1) 7.2 MB ⬆️ 8.0 kB (0.11%) 9.7 MB ⬆️ 19.5 kB (0.2%) ⏳ Needs approval
HackerNews
com.emergetools.hackernews.snapshots
3.4 (1) 8.0 MB ⬆️ 27.4 kB (0.34%) 13.6 MB ⬆️ 130.4 kB (0.98%) N/A

HackerNews 3.4 (1)
com.emerge.hn.Hacker-News

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 19.5 kB (0.2%)
Total download size change: ⬆️ 8.0 kB (0.11%)

Largest size changes

Item Install Size Change
HackerNews.SettingsScreen.body ⬆️ 4.3 kB
📝 HackerNews.SettingsRow.body ⬆️ 3.8 kB
📝 HackerNews.LoginRow.body ⬆️ 3.6 kB
SwiftUI.View.View ⬆️ 856 B
📝 HackerNews.SettingsRow.value witness ⬆️ 604 B
View Treemap

Image of diff

HackerNews 3.4 (1)
com.emergetools.hackernews.snapshots

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 130.4 kB (0.98%)
Total download size change: ⬆️ 27.4 kB (0.34%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 61.3 kB
HackerNews.SettingsScreen.body ⬆️ 11.7 kB
📝 HackerNews.LoginRow.body ⬆️ 6.2 kB
📝 HackerNews.SettingsRow.body ⬆️ 4.1 kB
Code Signature ⬆️ 3.3 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@emerge-tools
Copy link

emerge-tools bot commented Jan 22, 2025

📸 Snapshot Test

2 modified, 2 added, 80 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews
com.emergetools.hackernews.snapshots
2 0 2 0 62 0 ⏳ Needs approval
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
0 0 0 0 18 0 N/A

🛸 Powered by Emerge Tools

@trevor-e trevor-e merged commit e5cc29a into main Jan 22, 2025
6 of 7 checks passed
@trevor-e trevor-e deleted the settings-screen-design branch January 22, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants