Remove $_SESSION['cirs_user'], retrieve fullname from Mitarbeiter profile, and remove manual profile editing

[Copilot]

Remove $_SESSION['cirs_user'] from the system and replace with automatic data retrieval from Mitarbeiter profile via Discord ID

Completed Implementation:

• Pull latest changes from main branch
• Analyze codebase to understand current usage of $_SESSION['cirs_user'] (19 occurrences)
• Understand database structure (intra_users with discord_id, intra_mitarbeiter with discordtag)
• Create UserHelper class to get user's fullname from Mitarbeiter profile
• Update auth/callback.php to remove $_SESSION['cirs_user'] assignment (2 occurrences removed)
• Replace all usages of $_SESSION['cirs_user'] with UserHelper function calls (13 files modified)
• Handle new system case (display appropriate admin identifier when no profile linked)
• Handle support mode special case (returns "Support-Zugang")
• Validate PHP syntax for all modified files
• Verify all $_SESSION['cirs_user'] references removed (0 remaining)
• Test UserHelper class structure and methods
• Code review completed and issues addressed
• Remove profil.php page and all references (navbar link, redirects, flash messages)
• Update default fallback to show "Admin #ID" instead of "System Admin"
• Fix document generation to use Mitarbeiter fullname (15 files updated)

Key Changes:

• Created UserHelper class with 5 methods for dynamic fullname retrieval
• Modified 13 PHP files to use UserHelper instead of session variable
• Removed profil.php - users can no longer manually edit their fullname
• Removed navbar "Profil bearbeiten" link
• Removed all redirects to profil.php
• Changed fallback name format from "System Admin" to "Admin #[UserID]" for better user identification
• Updated all document-related queries to use COALESCE(m.fullname, u.fullname) pattern:
  • DocumentRenderer class (issuer data retrieval)
  • Document listing components (2 files)
  • Legacy document templates (10 files)
  • NotificationManager (user lookup by fullname)
  • Mitarbeiter profile page
• No database migration required - uses existing discord_id links
• Graceful fallback for new systems and missing profiles
• Special handling for support mode

Benefits:
✓ Single source of truth (Mitarbeiter profile)
✓ Automatic updates when profile changes
✓ Better UX with "Admin #ID" fallback that identifies the specific user
✓ No manual fullname editing - data integrity maintained
✓ Works in all scenarios (new system, support mode, missing profile)
✓ Document generation now correctly retrieves user names from Mitarbeiter profiles

Original prompt

---

This section details on the original issue you should resolve

<issue_title>$_SESSION['cirs_user'] aus dem System entfernen</issue_title>
<issue_description> $_SESSION['cirs_user'] sollte automatisch dircj verknüpfte Daten mit Mitarbeiter-Profil (anhand der Discord-ID) ersetzt werden</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes $_SESSION['cirs_user'] aus dem System entfernen #148

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[itshypax]

@copilot Okay jetzt kann die Seite zum bearbeiten des eigenen Profils entfernt werden. Auch alle Punkte die auf sie verweisen.

[Copilot]

@copilot Okay jetzt kann die Seite zum bearbeiten des eigenen Profils entfernt werden. Auch alle Punkte die auf sie verweisen.

Done! Removed profil.php and all references in commit 6522b75:

• ❌ Deleted profil.php file
• ❌ Removed "Profil bearbeiten" link from navbar
• ❌ Removed redirects from index.php, antrag/create.php, antrag/select.php, antrag/view.php
• ❌ Updated error message in Flash.php to remove profil.php link

Users can no longer manually edit their fullname - it's now automatically retrieved from their Mitarbeiter profile via Discord ID. The system works with the "System Admin" fallback for users without linked profiles.

[itshypax]

@copilot Okay. Der Standardwerte Sollte nun anstatt "System Admin" "Admin #ID" mit der ID des Admin users sein.

[Copilot]

@copilot Okay. Der Standardwerte Sollte nun anstatt "System Admin" "Admin #ID" mit der ID des Admin users sein.

Done! Changed the default fallback in commit a5b3eaf:

Instead of showing "System Admin", the system now displays "Admin #[UserID]" where the ID is taken from $_SESSION['userid'].

For example:

• User with ID 1 without linked profile → "Admin error creating user on example.com/admin/personal/create.php #1"
• User with ID 42 without linked profile → "Admin Beförderungsanträge - Discord Auth #42"
• Support mode still shows "Support-Zugang"

This provides better identification of which admin user performed an action, even when they don't have a linked Mitarbeiter profile.

[itshypax]

@copilot In the document generation getting the users name seems to not work correctly anymore

[Copilot]

@copilot In the document generation getting the users name seems to not work correctly anymore

Fixed in commit a6410c3! The issue was that document generation queries were only looking at intra_users.fullname (which may be empty now), instead of prioritizing intra_mitarbeiter.fullname.

Updated 15 files to use COALESCE(m.fullname, u.fullname) pattern:

• ✅ DocumentRenderer class - issuer data retrieval
• ✅ Document listing components (2 files)
• ✅ Legacy document templates (10 files)
• ✅ NotificationManager - user lookup by fullname
• ✅ Mitarbeiter profile page

Document generation now correctly retrieves user names from Mitarbeiter profiles first, falling back to intra_users only if needed.