Replace leftover Bootstrap classes with ignis components#326
Merged
Conversation
Badges, alerts and buttons in the core settings pages and the knowledge-base templates still used Bootstrap utility classes that only survive through the compat layer. They now use the existing design-system pieces: ignis-chip (with status variants), ignis-alert and ignis-btn. eNOTF keeps its own Bootstrap bundle on purpose. The modal attributes (data-bs-toggle/-dismiss) and data-bs-theme stay for now: four compat selectors still key off the theme attribute, so those fall to the dialog migration.
✅ Alle Checks bestanden7 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan – Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Badges, alerts and buttons in the core settings pages (plugins, telemetry, vehicles) and the knowledge-base templates still used Bootstrap utility classes (
badge text-bg-*,alert alert-*,btn btn-*) that only survive through the compat layer. They now use the existing design-system pieces:ignis-chipwith status variants,ignis-alert,ignis-btn.Deliberately out of scope:
data-bs-toggle/-dismiss,btn-close,modal fade, 23 files) anddata-bs-theme(199 files, four compat selectors key off it) — those fall to the dialog-system migration as its own project.