fix: do not report committed=true for empty commit SHA - #757
Conversation
simple-git can resolve successfully with an empty commit hash when no commit was actually created; keep the committed output accurate. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 57 seconds You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR tightens the GitHub Action’s commit behavior so it only reports committed=true when simple-git returns a non-empty commit SHA, avoiding false-positive “success” signals for no-op commits.
Changes:
- Add a guard to treat an empty
data.commitas a failure instead of reportingcommitted=true. - Update the compiled runtime bundle (
lib/index.js) to include the same empty-SHA protection.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main.ts |
Adds an explicit empty-SHA check after git.commit() before setting commit-related outputs. |
lib/index.js |
Updates the built distribution output to reflect the empty-SHA check at runtime. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // simple-git can resolve with an empty SHA when no commit was created | ||
| // (e.g. nothing left to commit). Do not report a false success. | ||
| if (!data.commit) { | ||
| throw new Error( | ||
| 'Commit did not produce a SHA; refusing to report committed=true.', |
Let empty-SHA failures reject so the outer catch stops the action instead of continuing after setFailed. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
committedoutput totruewhengit.commit()returns a non-empty SHA.committedno longer get a false success signal.Test plan
npm test)committed=falsecommitted=trueand populatescommit_sha/commit_long_shaMade with Cursor