Fix cargo lock updater workflow

[dc2917]

Description

This PR fixes the workflow to update Cargo.lock weekly. At present, the workflow creates a new branch with an updated Cargo.lock, but doesn't create a PR for that branch.

• This PR creation step uses a variable from the branch creation step, and this variable was not being accessed correctly since that step did not have an id.
• That step now does have an id, which is now referenced to obtain the success/fail outcome of branch creation.
• The PR creation was set to run if success != true, but it is now set to run if success != false (i.e. success == true).

Fixes #1380

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc
• Update release notes for the latest release if this PR adds a new feature or fixes a bug
  present in the previous release

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (b044c19) to head (93a8e31).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1407   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files          58       59    +1     
  Lines        8367     8367           
  Branches     8367     8367           
=======================================
  Hits         7482     7482           
  Misses        564      564           
  Partials      321      321           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tsmbland]

Looks good! I guess we'll see next Thursday whether this works...

[tsmbland]

Looks good! I guess we'll see next Thursday whether this works...

Or can we manually trigger this to check sooner?

[dalonsoa]

If it works, all good!