Skip to content

Exclude benchmark data from pre-commit - #1533

Merged
tsmbland merged 1 commit into
mainfrom
exclude_benches_from_pre_commit
Sep 3, 2026
Merged

Exclude benchmark data from pre-commit#1533
tsmbland merged 1 commit into
mainfrom
exclude_benches_from_pre_commit

Conversation

@tsmbland

@tsmbland tsmbland commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Otherwise this ends up getting flagged and fixed by the bot in an unrelated PR (e.g. see #1524)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland
tsmbland marked this pull request as ready for review September 3, 2026 12:37
Copilot AI lite review requested due to automatic review settings September 3, 2026 12:37
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.95%. Comparing base (7cd741d) to head (7443a71).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files          61       61           
  Lines        9050     9050           
  Branches     9050     9050           
=======================================
  Hits         8231     8231           
  Misses        500      500           
  Partials      319      319           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, targeted pre-commit exclusion update and the excluded paths exist and are precisely matched.

Pull request overview

This PR updates the repository’s pre-commit configuration to prevent benchmark fixture data from being reformatted/flagged during unrelated changes, reducing noise in future PRs.

Changes:

  • Extend the global exclude regex to also skip benches/benchmark-data.json in pre-commit.
  • Tighten the schemas/table-schema.json exclusion by escaping . to match the literal filename.
File summaries
File Description
.pre-commit-config.yaml Updates the global exclude regex to omit benchmark JSON data (and precisely match the table schema filename).
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dc2917 dc2917 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tsmbland
tsmbland merged commit d89071b into main Sep 3, 2026
10 checks passed
@tsmbland
tsmbland deleted the exclude_benches_from_pre_commit branch September 3, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants