Exclude benchmark data from pre-commit - #1533
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 61 61
Lines 9050 9050
Branches 9050 9050
=======================================
Hits 8231 8231
Misses 500 500
Partials 319 319 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, targeted pre-commit exclusion update and the excluded paths exist and are precisely matched.
Pull request overview
This PR updates the repository’s pre-commit configuration to prevent benchmark fixture data from being reformatted/flagged during unrelated changes, reducing noise in future PRs.
Changes:
- Extend the global
excluderegex to also skipbenches/benchmark-data.jsonin pre-commit. - Tighten the
schemas/table-schema.jsonexclusion by escaping.to match the literal filename.
File summaries
| File | Description |
|---|---|
| .pre-commit-config.yaml | Updates the global exclude regex to omit benchmark JSON data (and precisely match the table schema filename). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Otherwise this ends up getting flagged and fixed by the bot in an unrelated PR (e.g. see #1524)
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks