Restructure input data for example models#672
Merged
Conversation
…ellingLab/MUSE_OS into input_structure
…ellingLab/MUSE_OS into input_structure
Collaborator
Author
|
@martinstringer Have a quick look at the default model linked above and let me know what you think. I'm not changing the contents of any of the files (except the settings file), just restructuring. It's almost what we discussed, but I've got rid of the input/global_input_files folder as I don't really think it's necessary. All just convention though, any structure will still work as long as the files are linked correctly in the settings file |
Collaborator
Author
|
@dalonsoa This one's probably annoying to review and I'm keen to avoid marge conflicts so going to merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructuring the example models to be clearer for new users.
Easiest just to look at the new version of the default model
Main changes:
wizard.pyto work with the new structuretest_factory_constraints_passed_to_agentsbecause it was annoying me (oops)This is just about changing the example models rather than the code, so shouldn't have any effect on other models. Users can still structure their files however they want as long as they link their files properly in the settings file, but I think the structure here is simpler/less convoluted than what we had before so should be clearer for new users.
Notes:
modify-time-frameworktutorial model. I can't conceive why, but that model was already giving strange results (see Odd results when existing capacity data doesn't match the time framework [BUG] #371) so I'm not too concerned, and perhaps there might be a clue here for fixing that issueFixes #666