Skip to content

refactor(regions)!: rename RegionIntersection to RegionUnion - #2983

Merged
octylFractal merged 1 commit into
EngineHub:masterfrom
masonakdev:refactor/regions/WE-2982
Jul 4, 2026
Merged

refactor(regions)!: rename RegionIntersection to RegionUnion#2983
octylFractal merged 1 commit into
EngineHub:masterfrom
masonakdev:refactor/regions/WE-2982

Conversation

@masonakdev

@masonakdev masonakdev commented Jul 4, 2026

Copy link
Copy Markdown

Summary

Renames RegionIntersection to RegionUnion to match its existing behavior.

Also updates related selection errors, API verification entries, and some minor cleanup items in RegionUnion.

Changes

  • Rename RegionIntersection to RegionUnion
  • Update union expand/contract keys and messages
  • Add the accepted core API break
  • Fix minor warnings in RegionUnion

Testing

  • ./gradlew :worldedit-core:compileJava
  • ./gradlew :verification:checkCoreApiCompatibility
    • Note: checkCoreApiCompatibility still fails due to unrelated existing API changes. The RegionIntersection removals are accepted by the updated verification file.

Fixes #2982

@masonakdev
masonakdev force-pushed the refactor/regions/WE-2982 branch from 89d6c5a to d8bd7de Compare July 4, 2026 19:41
@masonakdev
masonakdev marked this pull request as ready for review July 4, 2026 19:42
@masonakdev
masonakdev requested a review from a team as a code owner July 4, 2026 19:42
Comment thread worldedit-core/src/main/java/com/sk89q/worldedit/regions/RegionUnion.java Outdated
@masonakdev
masonakdev force-pushed the refactor/regions/WE-2982 branch 3 times, most recently from b7b3c21 to 774c7f8 Compare July 4, 2026 20:13
@masonakdev
masonakdev requested a review from octylFractal July 4, 2026 20:14
Rename to match existing union behavior, update selection errors, and accept intentional API break.

BREAKING CHANGE: RegionIntersection has been removed. Use RegionUnion instead.
Refs: EngineHub#2982
@masonakdev
masonakdev force-pushed the refactor/regions/WE-2982 branch from 774c7f8 to 875d605 Compare July 4, 2026 20:16
@octylFractal octylFractal self-assigned this Jul 4, 2026
@octylFractal octylFractal added the type:tech-debt Task for cleaning up tech debt that has accumulated in the code base label Jul 4, 2026
@octylFractal octylFractal added this to the 8.0.0 milestone Jul 4, 2026
@octylFractal octylFractal linked an issue Jul 4, 2026 that may be closed by this pull request
@octylFractal
octylFractal enabled auto-merge July 4, 2026 20:38
@octylFractal

Copy link
Copy Markdown
Member

Thank you for your contribution!

@octylFractal
octylFractal added this pull request to the merge queue Jul 4, 2026
Merged via the queue into EngineHub:master with commit 93a216e Jul 4, 2026
2 checks passed
@masonakdev
masonakdev deleted the refactor/regions/WE-2982 branch July 4, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:tech-debt Task for cleaning up tech debt that has accumulated in the code base

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename RegionIntersection to RegionUnion

2 participants