Skip to content

Allow custom biomes in bukkit#2253

Merged
octylFractal merged 1 commit into
EngineHub:version/7.2.xfrom
Brokkonaut:bukkit-custombiomes
Feb 21, 2023
Merged

Allow custom biomes in bukkit#2253
octylFractal merged 1 commit into
EngineHub:version/7.2.xfrom
Brokkonaut:bukkit-custombiomes

Conversation

@Brokkonaut
Copy link
Copy Markdown
Contributor

More and more servers use data packs with custom biomes, so i think it would be nice if worldedit supports them.

@me4502
Copy link
Copy Markdown
Member

me4502 commented Jan 29, 2023

Due to the changes in this PR, it would make sense for it to target master rather than the release branch.

Also, this PR here already adds a way to add registry values from within adapters on the Bukkit WE platform. It'd likely make sense for this PR to use that method added in that PR. It's just waiting on octy to review it

@Brokkonaut
Copy link
Copy Markdown
Contributor Author

I would prefer to have it in 7.2.x, because it does not change any api or so, it just allows that feature on the bukkit platform that is already available on other platforms. but if that is not possible, i can retarget it.

for the way how the data from the registry is loaded, yes i can change that

Copy link
Copy Markdown
Member

@octylFractal octylFractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, should be merged after #2239

@octylFractal
Copy link
Copy Markdown
Member

Oh, that's master only. Hmmm. I guess we can resolve the conflict manually.

@octylFractal octylFractal merged commit ab79341 into EngineHub:version/7.2.x Feb 21, 2023
@octylFractal octylFractal modified the milestones: 7.2.13, 7.2.14 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants