Fix structure block CUI resetting selections cross-world.#2561
Merged
wizjany merged 1 commit intoversion/7.3.xfrom Jun 26, 2024
Merged
Fix structure block CUI resetting selections cross-world.#2561wizjany merged 1 commit intoversion/7.3.xfrom
wizjany merged 1 commit intoversion/7.3.xfrom
Conversation
me4502
approved these changes
Jun 25, 2024
Previously, if a world override was active (e.g. via //world), createStructureBlock would always attempt to check the player (entity) world rather than their selection world. This led to the selection getting reset immediately. Now, we first check if there's anything to render (i.e. if the selection is in the current world) before attempting to get the selection from the player's session.
wizjany
force-pushed
the
fix/drawsel-resets-selection-world
branch
from
04826c9 to
dc329ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a world override was active (e.g. via //world), createStructureBlock would always attempt to check the player (entity) world rather than their selection world. This led to the selection getting reset immediately. Now, we first check if there's anything to render (i.e. if the selection is in the current world) before attempting to get the selection from the player's session.