Cleanup registry init #2583
Merged
Cleanup registry init #2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitAdapter.java
Outdated
Show resolved
Hide resolved
worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitAdapter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Octavia Togami <octavia.togami@gmail.com>
me4502
force-pushed
the
chore/cleanup-registry-init
branch
from
201048f to
4a5e77e
Compare
octylFractal
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty minor PR that cleans up a few of the Bukkit Material API usages to be a bit cleaner / use more modern APIs, as well as reduces calls to
toStringof NamespacedKey/ResourceLocation. Also disables legacy ID conversions for the internal parser used for adapters in Bukkit, which should theoretically speed it up a little bit given it doesn't need to do legacy parsing