Re-enable this-escape warning, suppress as needed#2953
Draft
octylFractal wants to merge 5 commits intoversion/7.4.xfrom
Draft
Re-enable this-escape warning, suppress as needed#2953octylFractal wants to merge 5 commits intoversion/7.4.xfrom
this-escape warning, suppress as needed#2953octylFractal wants to merge 5 commits intoversion/7.4.xfrom
Conversation
No code yet
This also makes Adapter an abstract class implemented by the platforms, which expose their adapter back to coremc and also to other mods.
ANTLR now suppresses it properly. We also need to generally suppress it for now, since we use a lot of weird initialization patterns. Cleaning these up would be nice in the future.
octylFractal
added
the
type:tech-debt
github-project-automation
Bot
moved this to In progress
in Octy's All-in-One Task List For EngineHub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANTLR now suppresses it properly. We also need to generally suppress it for now, since we use a lot of weird initialization patterns. Cleaning these up would be nice in the future.
Stacked with #2951. Will un-draft after that merges.