Port buildlogic from WorldEdit#2100
Merged
wizjany merged 2 commits intoEngineHub:version/7.0.xfrom Jul 22, 2024
Merged
Conversation
octylFractal
approved these changes
Jul 11, 2024
Member
octylFractal
left a comment
octylFractal
left a comment
There was a problem hiding this comment.
LGTM if you fix the end of file newlines (they should be present)
me4502
added a commit
to EngineHub/CraftBook
that referenced
this pull request
Jul 11, 2024
Fairly heavily based on EngineHub/WorldGuard#2100, with a lot of CraftBook-specific changes and pulling some extras from WorldEdit
Definitely did not accidentally make a 40MB jar halfway through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to port the current build logic from WorldEdit to WorldGuard.
The project compiles fine, and the jars look similar enough from a quick glance. Limited testing in Minecraft showed no apparent issues. The only differences I've noticed:
Notes:
-Werrorin the compilerArgs for now -suppressingaddressing all of the deprecation warnings should be a seperate PR