Dev ensprod 8249 #10
Merged
Dev ensprod 8249 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not merge with master.
marcoooo
reviewed
Sep 30, 2022
vinay-ebi
reviewed
Sep 30, 2022
marcoooo
suggested changes
Sep 30, 2022
Contributor
marcoooo
left a comment
marcoooo
left a comment
There was a problem hiding this comment.
I still can't really see the ManyToMany relationships as we discussed and detailed here: https://docs.sqlalchemy.org/en/14/orm/basic_relationships.html#many-to-many
We'll need to discuss this pattern
marcoooo
approved these changes
Oct 7, 2022
… directly under root path, so empty on travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple tests and a test database.
The classes:
have been converted to ORM in api.py.
The remainder of the classes within the file need to be converted
Please leave me with comments so I can improve my style and methods for the future.