block HTTP redirects for image loading - #2327
Merged
TheNoumanDev merged 2 commits intoJul 27, 2026
Merged
Conversation
TheNoumanDev
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR blocks HTTP redirects for image loading in the Ensemble Image widget to prevent potential redirect-based attacks (SSRF). A custom
RedirectBlockingHttpClientis used both for individual image requests and within the image cache manager.Related Issue
N/A
Type of Change
What Has Changed
RedirectBlockingHttpClientclass that prevents HTTP redirects by settingfollowRedirects = falseand throwingClientExceptionon 3xx responsesEnsembleImageCacheManagercache key toensembleImageCacheKeyNoRedirectto invalidate old cache entrieserrorBuildercallback to cached network images for graceful fallbackhttpClient: RedirectBlockingHttpClient()to cached network image requestsHttpFileServicewithRedirectBlockingHttpClientin cache managerHow to Test
flutter test modules/ensemble/test/widget/image_widget_test.dartClientExceptionScreenshots / Videos
N/A
Checklist
flutter analyzeand addressed any new warningsflutter testand all tests pass