Skip to content

Conversation

@gsong
Copy link
Contributor

@gsong gsong commented Apr 2, 2021

Just as the title says. 😉

@gsong gsong requested review from josh-heyer and pipetogrep April 2, 2021 23:04
@josh-heyer josh-heyer temporarily deployed to edb-docs-adv-docs-cnp-v-pqses6 April 2, 2021 23:04 Inactive
@gsong gsong force-pushed the docs/cnp/v1.2.0 branch from dd75f37 to 12c60c9 Compare April 6, 2021 15:33
@josh-heyer josh-heyer temporarily deployed to edb-docs-adv-docs-cnp-v-pqses6 April 6, 2021 15:33 Inactive
Copy link
Contributor

@josh-heyer josh-heyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Realized while reviewing that we'd missed an admonition type: "hint". Addressing this in #1207

@gsong gsong merged commit 3bd5827 into develop Apr 6, 2021
@gsong gsong deleted the docs/cnp/v1.2.0 branch April 6, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants