Skip to content

[codex] Document optional signing key id#11

Closed
FakeGeek92 wants to merge 2 commits into
pre_publishfrom
wk/op/publish
Closed

[codex] Document optional signing key id#11
FakeGeek92 wants to merge 2 commits into
pre_publishfrom
wk/op/publish

Conversation

@FakeGeek92

Copy link
Copy Markdown

Summary

  • Document SIGNING_KEY_ID as optional for PublishPlugin Central release setup.
  • Keep the signing key id normalization fallback covered by workflow/script tests.

Validation

  • python3 .github/scripts/ensure_publish_version_test.py
  • python3 .github/scripts/normalize_signing_key_id_test.py
  • python3 .github/scripts/sync_readme_publish_version_test.py
  • python3 .github/scripts/publish_plugin_central_workflow_test.py
  • ./gradlew :plugin_base:build --stacktrace
  • ./gradlew :plugin_base:publishToMavenLocal --stacktrace
  • python3 .github/scripts/validate_publish_plugin_publications.py
  • python3 .github/scripts/sync_readme_publish_version.py --check
  • ./gradlew :plugin_base:publishAllPublicationsToCentralStagingRepository -PcentralPublish=true --dry-run --stacktrace

@wk1995 wk1995 closed this Jul 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06102aecde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment on lines +552 to +555
可选 secret:

```text
.github/workflows/publish-plugin-central.yml
SIGNING_KEY_ID

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not mark SIGNING_KEY_ID optional for callers

In the business-project reusable workflow section, this says SIGNING_KEY_ID can be omitted, but .github/workflows/central-publish.yml still declares SIGNING_KEY_ID as a required workflow_call secret and always maps it into ORG_GRADLE_PROJECT_signingInMemoryKeyId. If an org follows this doc and removes that secret while calling the workflow with secrets: inherit, the reusable workflow fails validation before Gradle can infer the key id. Either make the reusable workflow treat the secret as optional/normalize it there, or keep this secret documented as required for callers.

Useful? React with 👍 / 👎.

@wk1995
wk1995 deleted the wk/op/publish branch July 6, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants