Skip to content

Reinstate QueryDocumentsAsync SQL implementation - #10

Merged
mrdevrobot merged 3 commits into
feature/snapshotsfrom
copilot/sub-pr-5-one-more-time
Jan 26, 2026
Merged

Reinstate QueryDocumentsAsync SQL implementation#10
mrdevrobot merged 3 commits into
feature/snapshotsfrom
copilot/sub-pr-5-one-more-time

Conversation

Copilot AI commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Description

The QueryDocumentsAsync method in SqlitePeerStore was replaced with a placeholder returning empty results, breaking PeerCollection.Find and query-based APIs.

Restored the complete SQL-based query implementation with:

  • Query expression translation via SqlQueryTranslator
  • Paging support (LIMIT/OFFSET for skip/take parameters)
  • Collection filtering for both per-collection and legacy table modes
  • Field ordering with json_extract for custom fields, defaulting to Key
  • Proper type conversion for IsDeleted field (int → bool)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • QueryDocumentsAsync_ShouldSupportPaging test validates paging functionality
  • All 26 persistence layer tests pass
  • CodeQL security scan shows no vulnerabilities

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 26, 2026 22:51
Co-authored-by: mrdevrobot <12503462+mrdevrobot@users.noreply.github.com>
Co-authored-by: mrdevrobot <12503462+mrdevrobot@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on snapshot implementation Reinstate QueryDocumentsAsync SQL implementation Jan 26, 2026
Copilot AI requested a review from mrdevrobot January 26, 2026 22:56
@mrdevrobot
mrdevrobot marked this pull request as ready for review January 26, 2026 23:01
@mrdevrobot
mrdevrobot merged commit 2723ead into feature/snapshots Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants