Fix empty catch blocks in SqlitePeerStore transaction rollback handling

[Copilot]

Description

Addressed code review feedback regarding empty catch blocks that silently swallowed exceptions during transaction rollback attempts in SqlitePeerStore.cs.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Changes Made

• Added exception logging for all transaction rollback failures with LogWarning level
• Added missing rollback attempt in PruneOplogAsync general exception handler for consistency
• Refactored to multi-line format for improved readability

Before:

catch (Exception ex)
{
    _logger.LogError(ex, "Failed to apply batch");
    try { transaction.Rollback(); } catch { }
    throw;
}

After:

catch (Exception ex)
{
    _logger.LogError(ex, "Failed to apply batch");
    try
    {
        transaction.Rollback();
    }
    catch (Exception rollbackEx)
    {
        _logger.LogWarning(rollbackEx, "Failed to rollback transaction after batch failure");
    }
    throw;
}

How Has This Been Tested?

• Code review completed
• CodeQL security scan (0 alerts)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.