fix(studio): use shell mode for spawn on Windows#1025
Merged
Conversation
On Windows, Node's spawn() cannot execute .cmd/.bat wrappers (e.g. npm-installed agentv.cmd) without shell:true, causing ENOENT errors when clicking "Re-run with Filters" in Studio. Closes #1024 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
289014b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46cfafb8.agentv.pages.dev |
| Branch Preview URL: | https://fix-1024-spawn-error.agentv.pages.dev |
- content-preprocessor.test.ts: double-escape backslash in inline script regex so split() handles Windows paths - llm-grader-multimodal.test.ts: same fix for spreadsheet preprocessor test - evaluator-parser.test.ts: use [/\] in regex to match both path separators Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
christso
force-pushed
the
fix/1024-spawn-error
branch
from
3798254 to
289014b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell: process.platform === 'win32'to bothspawn()calls ineval-runner.ts(global and benchmark-scoped routes)spawn()cannot execute.cmd/.batwrappers (e.g. npm-installedagentv.cmd) withoutshell: true, causing ENOENT errors when clicking "Re-run with Filters" in Studioself/index.tswhich already usesshell: trueTest plan
bun run build)bun run typecheck)spawn('agentv', ['--version'])→ENOENT(exit code -4058) withoutshell: truespawn('agentv', ['--version'], { shell: true })→4.12.0(exit code 0)Closes #1024
🤖 Generated with Claude Code