fix: apply init values after reduction #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fix_reduction
branch
2 times, most recently
from
2fd8bbd to
53cb340
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avik-pal
force-pushed
the
ap/fix_reduction
branch
from
1ce0c89 to
e7d57dd
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
avik-pal
force-pushed
the
ap/fix_reduction
branch
from
e7d57dd to
83b0c20
Compare
avik-pal
force-pushed
the
ap/fix_reduction
branch
from
83b0c20 to
fbed525
Compare
wsmoses
approved these changes
Mar 12, 2025
wsmoses
pushed a commit
that referenced
this pull request
Mar 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stablehlo.reduce has somewhat different semantics compared to julia's reduce. Applying the init values later ensures that the results are consistent