Revert "fix: apply init values after reduction" #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6936dbe.
wsmoses
approved these changes
Mar 12, 2025
Member
wsmoses
left a comment
wsmoses
left a comment
There was a problem hiding this comment.
Can you open an issue of relevance to track
giordano
added a commit
to PRONTOLab/GB-25
that referenced
this pull request
Mar 12, 2025
Member
Author
|
PRONTOLab/GB-25#46 is running fine, which confirms #881 was indeed buggy. I also bumped the version so that we can tag it and have back a working state. Also, issue opened at #889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #881. I believe this broke the GB-25 code.