This repository was archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 266
This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Further improve websocket disconnect messages #466
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Component your feature request relates to
- Frontend
Problem your feature solves? Please describe.
Some further improvements in the disconnect message can make it event better.
Describe the solution you'd like
- Add a reason string here: https://github.com/EpicGames/PixelStreamingInfrastructure/blob/ce299ebd37d28965789cedb7cf0ede56b74a6d9d/Frontend/library/src/WebSockets/WebSocketController.ts#L202C1-L202C1
- Add a reason string here:
PixelStreamingInfrastructure/Frontend/library/src/WebRtcPlayer/WebRtcPlayerController.ts
Line 1674 in ce299eb
close() { - Improve this message:
ws.close(1008, 'Cannot parse'); - Add a reason string here:
function disconnectAllPlayers(streamerId) { - Elaborate what the unsupported message here was:
ws.close(1008, 'Unsupported message type'); - Consider whether this event should even close the websocket and not just log ^
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed