ci: change playwright testing#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Playwright testing setup by configuring parallel execution, improving CI reporting, and streamlining snapshot testing workflows. The changes focus on optimizing test performance and providing better feedback when visual tests fail.
- Enhanced Playwright configuration with parallel execution and environment-specific reporting
- Removed
maxDiffPixelRatioconfiguration from visual snapshot tests - Added automated snapshot difference detection and PR commenting in CI
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.ts | Added parallel execution, conditional reporters, and worker configuration |
| packages/tests/tests/home.test.ts | Removed maxDiffPixelRatio from screenshot assertions |
| packages/tests/tests/404.test.ts | Removed maxDiffPixelRatio from screenshot assertions |
| packages/next/package.json | Added single worker constraint for snapshot updates |
| .github/workflows/ci.yml | Enhanced CI with container setup, artifact uploads, and automated PR commenting |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:53
- Playwright version v1.54.2 does not exist. As of January 2025, the latest stable versions were in the 1.4x range. Please verify the correct Playwright version and update accordingly.
image: mcr.microsoft.com/playwright:v1.54.2-noble # Match the version in package.json
Playwright visual snapshot differences were detected.View the Playwright report to review the visual differences. |
Playwright visual snapshot differences were detected.View the Playwright report to review the visual differences. |
Owner
Author
|
/approve-snapshots |
Updating snapshots. Click here to see the status. |
🎉 Successfully updated and committed Playwright snapshots! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.