fix: add require_auth to accrue_postpaid_debt (#39) - #41
Open
leanworld7-netizen wants to merge 1 commit into
Open
fix: add require_auth to accrue_postpaid_debt (#39)#41leanworld7-netizen wants to merge 1 commit into
leanworld7-netizen wants to merge 1 commit into
Conversation
Anyone can currently call accrue_postpaid_debt to force-slash any user's collateral. Adding require_auth() ensures only the authorized user can trigger debt accrual on their own account.
Author
|
Requesting review from @KarenZita01 — this PR fixes the unauthenticated debt injection vulnerability (#39) by adding require_auth to accrue_postpaid_debt. This is a Critical severity finding per SECURITY.md section 4.1. Ready for review and merge. |
Author
|
Hi @KarenZita01, just following up on this PR which fixes the unauthenticated debt injection vulnerability from issue #39. The fix adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Problem
accrue_postpaid_debthas norequire_auth()call — anyone can call it to force-slash any user's collateral.Fix
Added
require_auth()at the start of the function body to ensure only the authorized user can trigger debt accrual on their own account.Severity
Critical — unauthorized collateral slashing per SECURITY.md §4.1 ($10K-$50K bounty tier)
Testing
require_auth()