Update Thrift to version 0.16 #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcserep
added
Kind: Refactor 🔃
Target: Developer environment
mcserep
requested changes
Oct 31, 2023
mcserep
requested changes
Oct 31, 2023
Collaborator
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
The GitHub CI should also be updated to use Thrift 16.
mcserep
requested changes
Nov 12, 2023
empty lines
Collaborator
Author
|
@mcserep |
mcserep
approved these changes
Nov 12, 2023
Collaborator
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Looks good now, nice work!
barnabasdomozi
pushed a commit
to barnabasdomozi/CodeCompass
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Thrift to version 0.16.
Since version 0.14, Thrift does not generate certain files, causing an error in CMake. To solve this, I made a wrapper function around the generation logic, so if some of the specified files are not generated, we manually create them.
There was an undocumented breaking change involving the java transport protocol implementations. The indexer service didn't handle all the exceptions correctly, leading to an API mismatch.
Since version 0.15, the javascript library provided by the
thriftnpm package also ships with the nodejs bindings. For environment detection, it internally uses a package calledbrowser-or-node. However, this plugin needs to be bundled with the generated javascript code, making it impossible to directly use it in the old webgui by simply referencing the thrift.js library downloaded from npm. Such change requires the introduction of a build system (likewebpackorbrowserify), and the proper conversion of CommonJS modules to AMD, so it goes beyond the scope of this PR. However, a traditional browser version of the library can still be acquired by downloading it directly from the Thrift repository with the proper version. I've decided to simply grab it from here and put it into the appropriatescriptsdirectory.The new webgui doesn't produce this behavior, as expected.
fixes #630