Refactors#57
Closed
Phil-Friderici wants to merge 5 commits into
Closed
Conversation
Phil-Friderici
force-pushed
the
refactor_data
branch
from
6b684e5 to
c8259d8
Compare
Seting $$service_enable to 'manual' will fail on RedHat like systems.
Using manual_startable will fail on other systems as it is unknown to them.
As 'manual' shouldn't be used in real life it gets removed.
Error message:
Failure/Error: it { is_expected.to compile }
error during compilation: Parameter enable failed on Service[postfix_service]:
Provider redhat must have features 'manual_startable' to set 'enable' to
'manual' (file: spec/fixtures/modules/postfix/manifests/init.pp, line: 507)
Phil-Friderici
force-pushed
the
refactor_data
branch
from
c717fa0 to
a522b1b
Compare
This gives more freedom of choice for parameters.
Contributor
Author
|
closed in favour of #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a preparation to add support for AlmaLinux & RockyLinux.
It moves OS specific data away from os.family to os.name. It uses one file for each OS flavor/version.