Add support for AlmaLinux & Rocky#58
Merged
Merged
Conversation
added 4 commits
December 22, 2022 12:43
Seting $$service_enable to 'manual' will fail on RedHat like systems.
Using manual_startable will fail on other systems as it is unknown to them.
As 'manual' shouldn't be used in real life it gets removed.
Error message:
Failure/Error: it { is_expected.to compile }
error during compilation: Parameter enable failed on Service[postfix_service]:
Provider redhat must have features 'manual_startable' to set 'enable' to
'manual' (file: spec/fixtures/modules/postfix/manifests/init.pp, line: 507)
Phil-Friderici
force-pushed
the
alma
branch
5 times, most recently
from
2b0ddc0 to
81570c1
Compare
added 2 commits
December 30, 2022 11:41
This gives more freedom of choice for parameters.
Phil-Friderici
force-pushed
the
alma
branch
2 times, most recently
from
84a8934 to
a7b80eb
Compare
Closed
Phil-Friderici
force-pushed
the
alma
branch
2 times, most recently
from
e549aca to
dd95cad
Compare
Phil-Friderici
changed the title
added 2 commits
January 2, 2023 11:45
anders-larsson
approved these changes
Jan 3, 2023
Contributor
Author
|
Thank you @anders-larsson, released as v2.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will move all module default values into OS specific hiera data. This is done because not all module default values are really default values for all OS flavours. Now we have one file per OS flavour which makes adding support for new OS flavours very easy.
The usage of os.family is migrated to use os.name. This allows more fine granular settings whenever needed.
The last commits will finally add support for AlmaLinux and Rocky.
Acceptance tests are only added for AlmaLinux and Rocky version 8. Puppet Litmus doesn't provide containers for newer versions yet. FacterDB doesn't provide facts for Rocky 9 yet, but it should work once it gets added to FacterDB.