[EFCPT CLI] Stored Procedure model not generated with CLI

[damien7792]

Bug description / exact reproduction steps

Hi,

I've been trying to generate models for tables and some stored procedures, but only models for tables are being created.

This is an extract from the json config file

"stored-procedures": [ { "name": "dbo.GetMyData" } ],

I ran FMTONLY for that stored procedure in SQL Management Studio, and it returned the columns of the result

But everytime I run it like this:

efcpt "data source=xxxx" mssql --input "xxx\efcpt-config.json" --verbose

It creates the models for the tables I have selected, but never the ones for the stored procedures.
Also, the "MyContextProcedures.cs" don't contain any reference to the stored procedure neither

The verbose logs don't show any warnings or errors.

What am I missing?
How can I fix this?

Thank you

Your code

{
  "$schema": "https://raw.githubusercontent.com/ErikEJ/EFCorePowerTools/master/samples/efcpt-config.schema.json",
  "tables": [
    {
      "name": "[dbo].[Supplier]"
    },
    {
      "name": "[dbo].[Client]"
    }
  ],
  "views": [
    {
      "exclusionWildcard": "*"
    }
  ],
  "stored-procedures": [
    {
      "name": "dbo.GetMyData"
    }
  ],
  "functions": [
    {
      "exclusionWildcard": "*"
    }
  ],
  "code-generation": {
    "enable-on-configuring": false,
    "type": "all",
    "use-database-names": false,
    "use-data-annotations": false,
    "use-nullable-reference-types": true,
    "use-inflector": false,
    "use-legacy-inflector": false,
    "use-many-to-many-entity": false,
    "use-t4": true,
    "remove-defaultsql-from-bool-properties": false,
    "soft-delete-obsolete-files": true,
    "discover-multiple-stored-procedure-resultsets-preview": false,
    "use-alternate-stored-procedure-resultset-discovery": false,
    "t4-template-path": null,
    "use-no-navigations-preview": false,
    "merge-dacpacs": false,
    "refresh-object-lists": false
  },
  "names": {
    "root-namespace": "MyProject",
    "dbcontext-name": "MyContext",
    "dbcontext-namespace": null,
    "model-namespace": null
  },
  "file-layout": {
    "output-path": "Models",
    "output-dbcontext-path": null,
    "split-dbcontext-preview": false,
    "use-schema-folders-preview": false,
    "use-schema-namespaces-preview": false
  },
  "type-mappings": {
    "use-DateOnly-TimeOnly": false,
    "use-HierarchyId": false,
    "use-spatial": false,
    "use-NodaTime": false
  },
  "replacements": {
    "preserve-casing-with-regex": false,
    "uncountable-words": [
      "Status",
      "Data"
    ]
  }
}

Stack traces

EF Core Power Tools version

No response

EF Core Power Tools CLI version

9.1.761

Database provider

MSSQL

Target framework

.NET 9.0

IDE

VS 2022 17.13.3

Additional features in use

• T4 templates
• SQL Server .dacpac
• Handlebars template

[ErikEJ]

@damien7792 You need to share a schema that reproduces thod if you want my help.

[damien7792]

Thanks for your answer. I've reproduced the issue with a test table and test stored procedure:

CREATE TABLE [dbo].[Z_TestTable](
	[Id] [int] NOT NULL,
	[Name] [varchar](50) NOT NULL,
	[CreateDateTime] [datetime] NOT NULL,
 CONSTRAINT [PK_Z_TestTable] PRIMARY KEY CLUSTERED 
(
	[Id] ASC
)
)

ALTER PROCEDURE [dbo].[GetZTestTable]
	@id int
AS
BEGIN
	SET NOCOUNT ON;

    -- Insert statements for procedure here
	SELECT *, 'hello' as AdditionalText from z_testtable where id = @id
END

"tables": [
    {
      "name": "[dbo].[z_testtable]"
    }
  ],
  "views": [
    {
      "exclusionWildcard": "*"
    }
  ],
  "stored-procedures": [
    {
      "name": "dbo.GetZTestTable"
    }
  ],
  "functions": [
    {
      "exclusionWildcard": "*"
    }
  ],

And when I run the efcpt, this is what I get:

public partial class ZTestTable
{
    public int Id { get; set; }

    public string Name { get; set; } = null!;

    public DateTime CreateDateTime { get; set; }
}

namespace MyProject.Data.Models
{
    public partial interface IMyModelProcedures
    {
    }
}

There's no class created for the stored procedure return model nor a method declared to call it.

Also, this is the tt templates that are being created and used:

Let me know if you need anything else to investigate

[ErikEJ]

I am unable to repro:

config file: C:\dev\GitHub\EFCorePowerTools\src\Core\efcpt.9\bin\Debug\net8.0\efcpt-config.json

1 tables found
1 stored procedures found

2 database objects discovered in 1,3 seconds

6 files generated in 3,6 seconds

output folder: C:\dev\GitHub\EFCorePowerTools\src\Core\efcpt.9\bin\Debug\net8.0\Models

namespace UBH.RazorPagesTest.Models
{
    public partial class GetZTestTableResult
    {
        public int Id { get; set; }
        [StringLength(50)]
        public string Name { get; set; } = default!;
        public DateTime CreateDateTime { get; set; }
        [StringLength(5)]
        public string AdditionalText { get; set; } = default!;
    }
}

[ErikEJ]

@damien7792 Ah! Your sp name is wrong! Must be quoted with brackets!

"name": "[dbo].[GetZTestTable]"

[ErikEJ]

If you like my free tools, I would be very grateful for a rating/review on Visual Studio Marketplace and/or a one-time or monthly sponsorship

[damien7792]

Good catch, thanks @ErikEJ
I didn't think the brackets were needed for stored procedures

Also, I noticed that if you only want entities, not the whole context ("type": "entities"), it will generate the models for tables, but not for stored procedure.

Thanks for your help!

[ErikEJ]

@damien7792

Also, I noticed that if you only want entities, not the whole context ("type": "entities"), it will generate the models for tables, but not for stored procedure.

Correct, this is by design