Kryo is inefficiency to handle the object that it is without non-param constructor

[maohui1993]

when I handle the javax.naming.Reference, Kryo will wait in ConstructorAccess.get(type). Of course, i had seted kryo.setInstantiatorStrategy(...).
let see:

[magro]

https://github.com/EsotericSoftware/reflectasm/blob/master/src/com/esotericsoftware/reflectasm/ConstructorAccess.java#L54 is synchronized (loader), I think the following accessClass = loader.loadClass(accessClassName); can be tried once workout synchronization, and if this fails the synchronized block is executed. Do you want to submit a pull request with this for reflectasm?

@NathanSweet WDYT?

[magro]

@maohui1993 Can you build reflectasm from this branch and use the related version (1.11.2-SNAPSHOT) in your app/project (explicitely add reflectasm as dependency) and see how it works?

[magro]

@maohui1993 Now that reflectasm is released with the change you can just try the latest kryo SNAPSHOT (check docs on SNAPSHOTs). How does it work for you?

[maohui1993]

oh, Im so sorry. recently, I busy at other thing, so I dont observe your answer, so thanks.

year, I also think it is result of ** synchronized (loader)**, and I will test it .

[maohui1993]

It is still inefficiency while I use reflectasm that its version(1.11.2).
. And I try to delete the synchronized of theprotected synchronized java.lang.Class<?> loadClass() that it is code in AccessClassLoader, bug it will wait in the line 91(ClassLoder.loderClass()). The threads will preemption the same classloader . Can I avoid synchronized, or make the loder become different? I will use a cache to test it

[magro]

@maohui1993 Yes, because there's a synchronized in class loading path threads will still be shown as blocked at some time (although ClassLoader.loadClass synchronizes on the class name). Are you sure that this (class loading) is a significant bottleneck besides the fact that threads are shown as blocked?

[maohui1993]

year,I have resolved it by add a cache. And heartfelt thanks to you.

[magro]

@maohui1993 Where have you added a cache?
Btw, now kryo snapshot includes the latest reflectasm with the removal of synchronized in AccessClassLoader.loadClass.

[maohui1993]

I have not commit it...