Skip to content

Reuse good maven pom.xml#23

Merged
NathanSweet merged 1 commit intoEsotericSoftware:masterfrom
tchemit:master
May 23, 2014
Merged

Reuse good maven pom.xml#23
NathanSweet merged 1 commit intoEsotericSoftware:masterfrom
tchemit:master

Conversation

@tchemit
Copy link
Contributor

@tchemit tchemit commented May 23, 2014

Here is a good pom.xml modified for github hosting.

I make the version 1.0.7.1, could you then create a such tag ?

When everything is ok to you, let me know I will push to maven central repository via OSSRH.

Cheers,

NathanSweet added a commit that referenced this pull request May 23, 2014
Reuse good maven pom.xml
@NathanSweet NathanSweet merged commit 60b4288 into EsotericSoftware:master May 23, 2014
NathanSweet added a commit that referenced this pull request May 23, 2014
@NathanSweet
Copy link
Member

I've changed the POM to 1.08 in the commit above. Also I changed the SCM to point to esotericsoftware/yamlbeans. Is this ok? If so I'll make a tag.

@tchemit
Copy link
Contributor Author

tchemit commented May 23, 2014

Yep that's fine to me.
Good, good, good :)Let's tag!

@NathanSweet
Copy link
Member

Done!

@tchemit
Copy link
Contributor Author

tchemit commented May 23, 2014

I just notice something strange in your tag (and master also).

We should use version 1.08 and not 1.0.8.

I prefer you change this before doing the maven release.

thanks.

@NathanSweet
Copy link
Member

Done.

On Fri, May 23, 2014 at 1:26 PM, Tony CHEMIT notifications@github.comwrote:

I just notice something strange in your tag (and master also).

We should use version 1.08 and not 1.0.8.

I prefer you change this before doing the maven release.

thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-43997214
.

@tchemit
Copy link
Contributor Author

tchemit commented May 23, 2014

Sorry again to bother you Nathan,

Perharps we could also add this (just after the model tag) to the pom to make release easier to OSSRH:

 <parent>
    <groupId>org.sonatype.oss</groupId>
    <artifactId>oss-parent</artifactId>
    <version>7</version>
  </parent>

@NathanSweet
Copy link
Member

Done.

On Fri, May 23, 2014 at 2:48 PM, Tony CHEMIT notifications@github.comwrote:

Sorry again to bother you Nathan,

Perharps we could also add this (just after the model tag) to the pom
to make release easier to OSSRH:

org.sonatype.oss oss-parent 7


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-44004513
.

@tchemit
Copy link
Contributor Author

tchemit commented May 23, 2014

I just release on ossrh now just wait two hours till it is on central.
Thanks Nathan to be so available on this one.

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants