Added /sell multipliers - #4761
Closed
justinmtech wants to merge 1 commit into
Closed
Conversation
This was a feature request @ EssentialsX#3934
Member
|
I think a better implementation of this would be like that suggested by Chew in the linked issue. Allow defining multipliers in the configuration as with home permissions, to not have to iterate everything and parse. |
Author
You're right. I will try to re-work this soon when I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #3934
Details
Proposed feature:
Sell Command multipliers! The idea is for servers to be able to control how much players can /sell their items for based on permissions. If a player has the permission "essentials.sell.multiplier.2", their items will sell with double worth. It works with decimals as well, and even values less than 1.
#3934
Environments tested:
OS: Windows 10
Java version: OpenJDK 17.0.1
Demonstration:
Screenshot: https://i.imgur.com/ju0jMUy.png
Here I give myself a diamond and sell it with no permissions (as op), then I give myself the "essentials.sell.multiplier.2" permission and as you can see, my sell price is double.
Plugin Download: https://www.dropbox.com/s/2qwzn2st8ln5i1q/EssentialsX-2.19.3-dev%2B6-739600e-sell-multipliers.jar?dl=0