Skip to content

fix(agents): install the ratified 2026-08-02 rulings — ingest denylist is NOT all workflows - #644

Merged
EtanHey merged 1 commit into
mainfrom
fix/install-ratified-agents-rulings
Aug 4, 2026
Merged

fix(agents): install the ratified 2026-08-02 rulings — ingest denylist is NOT all workflows#644
EtanHey merged 1 commit into
mainfrom
fix/install-ratified-agents-rulings

Conversation

@EtanHey

@EtanHey EtanHey commented Aug 3, 2026

Copy link
Copy Markdown
Owner

The brainlayer instruction file was grilled and ratified 2026-08-02 and never installed. It sat in gitignored docs.local/ for a day while the tracked file taught the wrong rule with authority.

Etan, 2026-08-03: "after it was ratified it should have been installed, and this is a fucking shame, really."

The load-bearing fix

AGENTS.md said exclusion covers brain-worker subagents and "workflow paths under wf_*". Etan today:

"That's very specific. It's not all workflows. I don't know why y'all keep thinking it's all workflows."
"the Weaver's workflow is built of session miners."

Now installed: exclusion is scoped to agents whose job is to read other agents' memory or JSONLsbrain-worker sub-agents and session-miner / weave workflow agents. Not all workflows. Adds the session-miner rule the ratified draft itself never stated (grepped: zero occurrences); his 08-03 ruling supersedes the 08-02 draft's silence.

Every agent that got this wrong got it wrong by reading the doc correctly. The doc was the bug.

Code drift flagged, not silently fixed

ingest_denylist.py:14 is ("~/.claude/projects/**/wf_*/**",) — excludes every workflow path and silently discards legitimate workflow-agent memory. Doc = ruling, code = defect. Code fix stays with the brainlayer lane.

Also installed — 4 ratified rulings that never landed

project-is-always-the-repo · rules-ride-in-instruction-files (BrainLayer injects context, is not law) · agent-authored-chunks-are-normal ("rules cite no source" is a non-finding) · pre-merge live-check against a DB copy.

⚠️ PR #605 contradicts this ruling — denies all Claude subagents incl. general-purpose/Explore and keeps all-wf_*. Should not merge as-is.

Note on --no-verify

Pushed with --no-verify, deliberately and per Etan's 2026-08-03 ruling: hooks exist to catch fixable tests and to stop outsiders merging into his daily tools — "They're not there to block you all from merging." This is one markdown file, 24 insertions, zero code; it cannot affect the 3,696-test Python suite that was gating it. Shape check passes.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only change to agent instructions; no code, DB, or ingest behavior is modified in this diff.

Overview
Updates AGENTS.md only — no runtime or ingest_denylist.py changes in this PR.

The BL-10 ingest denylist section is rewritten so exclusion applies only to agents whose job is reading other agents’ memory/JSONLs (brain-worker, session-miner / weave), not every path under wf_*. It clarifies that excluded sessions stay on disk but are not indexed, and quotes the 2026-08-03 ruling that Weaver-style workflows built from session miners should still ingest.

A known code drift callout documents that shipped DEFAULT_INGEST_DENYLIST still uses ~/.claude/projects/**/wf_*/** and is labeled a defect owned by the brainlayer lane — doc is ruling, code is not yet aligned.

Adds “Rulings that bind every agent” (ratified 2026-08-02): repo vs branch for project, rules live in instruction files (BrainLayer = context not law), agent-authored chunks / “rules cite no source” is a non-finding, and pre-merge live-check against a DB copy for stored-data changes.

Reviewed by Cursor Bugbot for commit e64eeb6. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix BL-10 denylist scope in AGENTS.md and ratify 2026-08-02 rulings

  • Clarifies that ingest_denylist exclusions apply only to brain-worker sub-agents and session-miner/weave workflow agents, not all workflows — the previous wording was ambiguous.
  • Adds explicit note that brain-worker and miner sessions are retained but not indexed, and that exclusions never delete source JSONL files.
  • Calls out a known defect in ingest_denylist.py where the current pattern excludes every workflow path contrary to the stated rule, with fix ownership assigned.
  • Appends a new 'Rulings that bind every agent' section ratified 2026-08-02 covering: worktree project identity, rule authority (only instruction files), agent-authored chunks policy, and a required pre-merge live-check against a DB copy for any stored-data-touching change.

Macroscope summarized e64eeb6.

…t denylist correctly

The brainlayer instruction file was grilled and RATIFIED 2026-08-02 and never
installed. It sat in docs.local/ (gitignored) for a day while the tracked file
kept teaching the wrong rule with authority.

Etan, 2026-08-03, verbatim: "after it was ratified it should have been
installed, and this is a fucking shame, really."

The load-bearing correction — AGENTS.md said only `brain-worker` subagents and
"workflow paths under wf_*" are excluded. Etan today: "That's very specific.
It's not all workflows. I don't know why y'all keep thinking it's all
workflows." and "the Weaver's workflow is built of session miners."

Correct rule, now installed: exclusion is scoped to agents whose job is to READ
OTHER AGENTS' MEMORY OR JSONLs — brain-worker sub-agents and session-miner /
weave workflow agents. NOT all workflows. Adds the missing session-miner rule
the ratified draft itself never stated.

Also flags the live code drift rather than hiding it: ingest_denylist.py:14 is
("~/.claude/projects/**/wf_*/**",), which excludes every workflow path and
silently discards legitimate workflow-agent memory. The doc is now the ruling;
the code is the defect. Code fix stays with the brainlayer lane.

Plus 4 ratified rulings that were never installed: project-is-always-the-repo,
rules-ride-in-instruction-files (BrainLayer injects context, is not law),
agent-authored-chunks-are-normal (rules-cite-no-source is a non-finding), and
the pre-merge live-check gate.

Shape unaffected — instruction-shape check passes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_289b68bb-8574-4553-83a6-39ffd672b84d)

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@EtanHey, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 09279536-3ba8-4edc-8291-c7565ced11d8

📥 Commits

Reviewing files that changed from the base of the PR and between 17c0247 and e64eeb6.

📒 Files selected for processing (1)
  • AGENTS.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtanHey
EtanHey merged commit c860230 into main Aug 4, 2026
9 checks passed
@EtanHey
EtanHey deleted the fix/install-ratified-agents-rulings branch August 4, 2026 13:19
EtanHey added a commit that referenced this pull request Aug 4, 2026
The 7 admin merges of 2026-08-04 (#645 #644 #643 #641 #633 #605 #602) bypassed CI,
landing import-order and formatting drift on main. Every PR's lint job inherits it.
Rebased onto #647 (949334a), which cleared the watchdog test blocking this push.

ruff check --fix + ruff format only; no behavioural change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant