fix(brainbar): pass contentIntegrity at the storedChunk lookup call site — main does not compile - #649
fix(brainbar): pass contentIntegrity at the storedChunk lookup call site — main does not compile#649EtanHey wants to merge 1 commit into
Conversation
#645 added `contentIntegrity` to `StoredChunk` and updated the write-with-readback path (BrainDatabase.swift:1406) but not the lookup path at :4701, so `swift build` fails with 22 errors across BrainBar and BrainBarDaemon. main does not compile. It landed because the 7 admin merges of 2026-08-04 bypassed CI — the same cause as the ruff drift fixed in #648. `--admin` skips the check that would have caught this. `storedChunk()` is a LOOKUP of an existing row, not a write-with-readback: no integrity comparison is performed there, so `nil` is the correct value rather than a fabricated measurement. Verified: swift build → 0 errors.
|
Warning Review limit reached
Next review available in: 23 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6f6d4b4d-d7bf-4698-b19a-4e307734d3b5) |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Closing as obsolete — superseded by #646, and NOT merging it as a no-op. Verified on current
Why it existed at all — my error, recorded: I diagnosed main's broken Swift build and wrote this fix without first checking whether an open PR already addressed it. #646 already contained the identical Nothing is lost: the fix shipped in #646 ( |
maindoes not build.swift buildfails with 22 errors acrossBrainBarandBrainBarDaemon.Cause
#645 added
contentIntegritytoStoredChunkand updated the write-with-readback path (BrainDatabase.swift:1406) but not the lookup path at:4701:It landed because the seven
--adminmerges of 2026-08-04 bypassed CI — the same root cause as the ruff drift fixed in #648.--admindoesn't skip one gate; it lets a red build become the base for every branch cut afterward. This is the third repair PR for that one decision.Fix
One argument at one call site.
storedChunk()is a lookup of an existing row, not a write-with-readback — no integrity comparison happens there, sonilis the truthful value rather than a fabricated measurement.Note:
Sources/BrainBarDaemon/BrainDatabase.swiftis a symlink to the BrainBar copy, so the 22 errors are 11 real ones seen through two targets and a single edit fixes both. Worth knowing before anyone "de-duplicates" the file.Verification
What this unblocks
brew upgradesilently revertsNote
Low Risk
Single-call-site compile fix with no behavior change beyond satisfying the updated initializer; lookup paths still do not perform integrity checks.
Overview
Restores
swift buildby updating thestoredChunklookup path to constructStoredChunkwith the newcontentIntegrityargument.The lookup only resolves an existing row ID and does not run write-time integrity verification, so
contentIntegrity: nilis passed instead of fabricating metrics.Reviewed by Cursor Bugbot for commit 9a1a39a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
StoredChunkinitializer call inBrainDatabaseto passcontentIntegrityThe
StoredChunkinitializer in BrainDatabase.swift was missing acontentIntegrityargument, causing a compile error onmain. The call site now passescontentIntegrity: nilexplicitly as the third argument.Macroscope summarized 9a1a39a.