Schedule: sort rooms with S-number first#1739
Conversation
Preview available
|
|
Thanks for the patch! We were discussing the problem with Marcin a few days ago, and in general I think it's better if we go with a predefined order of rooms – either coming directly from pretalx, or from programmeapi, or hardcoded in the the website. Some of the new things on the talk pages will require a predefined room order. A stable sorting algorithm would be also be good enough, but explicit order might be simpler and easier to understand and maintain. cc @nikoshell |
|
I think it'd be better to do the predefined order here in the website. |
Yep, we want do it on the website. |
|
I can update this PR. Here's the list of rooms:
What order would you like? |
I think this Tutorial days:
Conf days:
|
|
If rooms are not listed in the order, or if we do not give a pre-defined order, what would the behaviour be? To me, what makes sense in terms of sorting priorities:
The current new order in preview help me breathe better, so thank you! |
|
This PR sorts by the predefined order, and for rooms not listed there, they're put in alphabetical order at the end. |





Wednesday looks like:

But when you go to Thursday or Friday, suddenly "Glass Room" appears and moves the keynotes to the right:
Instead, sort rooms without an S-number ("Glass room", "Fishbowl") last:
This also means Monday/Tuesday change from summits then tutorials:
To tutorials then summits:
But I think that's fine.